Skip to content

feat(Inline editing): prevent editing read-only values - #2049

Merged
enjeck merged 1 commit into
mainfrom
feat/read-only-inline-editing
Sep 13, 2025
Merged

feat(Inline editing): prevent editing read-only values#2049
enjeck merged 1 commit into
mainfrom
feat/read-only-inline-editing

Conversation

@enjeck

@enjeck enjeck commented Sep 7, 2025

Copy link
Copy Markdown
Contributor

fixes #1980, and a follow up for #1958.
For inline editing in views, we prevent editing for read-only columns.
We also gray it out:
Screenshot from 2025-09-07 09-02-01

@enjeck enjeck self-assigned this Sep 7, 2025
@enjeck
enjeck requested a review from blizzz as a code owner September 7, 2025 08:33
@github-project-automation github-project-automation Bot moved this to 馃Л Planning evaluation (don't pick) in 馃摑 Productivity team Sep 7, 2025
@enjeck
enjeck changed the base branch from main to feature/readonly-columns-v2 September 7, 2025 08:33
Base automatically changed from feature/readonly-columns-v2 to main September 7, 2025 09:52
@enjeck
enjeck requested a review from silverkszlo September 11, 2025 06:28
-->
<template>
<div class="cell-datetime">
<div class="cell-datetime" :style="{ opacity: !canEditCell() ? 0.6 : 1 }">

@silverkszlo silverkszlo Sep 11, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a title would be great here and in the other divs with similar functionality: :title="!canEditCell() ? t('tables', 'Read only') : ''"

Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck
enjeck force-pushed the feat/read-only-inline-editing branch from aaf781a to 6cfeb69 Compare September 11, 2025 09:35

@silverkszlo silverkszlo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@enjeck
enjeck merged commit e61c40f into main Sep 13, 2025
50 of 52 checks passed
@enjeck
enjeck deleted the feat/read-only-inline-editing branch September 13, 2025 13:47
@github-project-automation github-project-automation Bot moved this from 馃Л Planning evaluation (don't pick) to 鈽戯笍 Done in 馃摑 Productivity team Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Inline editing: prevent editing read-only values

2 participants