Skip to content

fix: Tiptap editor and heading styles - #2041

Merged
enjeck merged 2 commits into
mainfrom
fix-tiptapmenu
Sep 5, 2025
Merged

fix: Tiptap editor and heading styles#2041
enjeck merged 2 commits into
mainfrom
fix-tiptapmenu

Conversation

@enjeck

@enjeck enjeck commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Fixes the headings and the rendering of the Tiptap editor. Having the styles in a "scoped" doesn't work. It's okay to leave it unscoped since we give a unique (hopefully) classname, and so shouldn't leak and affect other apps.

Before

Screenshot 2025-09-02 at 05 12 43

After

Screenshot 2025-09-02 at 05 42 25

@enjeck
enjeck requested a review from silverkszlo September 2, 2025 04:56
@enjeck enjeck self-assigned this Sep 2, 2025
@enjeck
enjeck requested a review from blizzz as a code owner September 2, 2025 04:56
@enjeck enjeck added the 3. to review Waiting for reviews label Sep 2, 2025
@github-project-automation github-project-automation Bot moved this to 馃Л Planning evaluation (don't pick) in 馃摑 Productivity team Sep 2, 2025
Comment thread src/shared/components/ncTable/partials/TiptapMenuBar.vue Outdated

@silverkszlo silverkszlo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, seems to work in Firefox and Chromium!

Signed-off-by: Enjeck C <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C <patrathewhiz@gmail.com>
@enjeck
enjeck merged commit 6e70ca2 into main Sep 5, 2025
49 of 52 checks passed
@enjeck
enjeck deleted the fix-tiptapmenu branch September 5, 2025 05:59
@github-project-automation github-project-automation Bot moved this from 馃Л Planning evaluation (don't pick) to 鈽戯笍 Done in 馃摑 Productivity team Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants