Skip to content

fix: Scope CSS styles - #2018

Merged
enjeck merged 4 commits into
mainfrom
scope-smartpicker-css
Aug 21, 2025
Merged

fix: Scope CSS styles#2018
enjeck merged 4 commits into
mainfrom
scope-smartpicker-css

Conversation

@enjeck

@enjeck enjeck commented Aug 20, 2025

Copy link
Copy Markdown
Contributor

To avoid these styles from leaking and affecting other apps

@enjeck
enjeck requested a review from silverkszlo August 20, 2025 07:47
@enjeck enjeck self-assigned this Aug 20, 2025
@enjeck enjeck added the 3. to review Waiting for reviews label Aug 20, 2025
@enjeck
enjeck requested a review from blizzz as a code owner August 20, 2025 07:47
@github-project-automation github-project-automation Bot moved this to 馃Л Planning evaluation (don't pick) in 馃摑 Productivity team Aug 20, 2025
@enjeck enjeck changed the title fix: Scope smartpicker CSS styles fix: Scope CSS styles Aug 20, 2025

@silverkszlo silverkszlo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SmartPicker.vue still contains the picker-content and picker-title classes, which don't exist anymore?

@AndyScherzinger AndyScherzinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃悩

@enjeck

enjeck commented Aug 21, 2025

Copy link
Copy Markdown
Contributor Author

SmartPicker.vue still contains the picker-content and picker-title classes, which don't exist anymore?

Thanks. I removed these

enjeck added 4 commits August 21, 2025 05:41
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck
enjeck force-pushed the scope-smartpicker-css branch from 4320f82 to 185a2ad Compare August 21, 2025 04:41
@enjeck
enjeck merged commit be49a84 into main Aug 21, 2025
52 checks passed
@enjeck
enjeck deleted the scope-smartpicker-css branch August 21, 2025 04:59
@github-project-automation github-project-automation Bot moved this from 馃Л Planning evaluation (don't pick) to 鈽戯笍 Done in 馃摑 Productivity team Aug 21, 2025
@enjeck

enjeck commented Aug 21, 2025

Copy link
Copy Markdown
Contributor Author

/backport to stable0.9

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Aug 21, 2025
@backportbot backportbot Bot mentioned this pull request Aug 21, 2025
2 tasks
@backportbot backportbot Bot removed the backport-request Pending backport by the backport-bot label Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants