Skip to content

feat: Inline editing support for html column - #2014

Merged
enjeck merged 1 commit into
mainfrom
feat/364-html
Aug 19, 2025
Merged

feat: Inline editing support for html column#2014
enjeck merged 1 commit into
mainfrom
feat/364-html

Conversation

@enjeck

@enjeck enjeck commented Aug 18, 2025

Copy link
Copy Markdown
Contributor

This adds inline editing support for the Html / "simple text"/ text long column type.
Part of #364

@enjeck
enjeck requested a review from silverkszlo August 18, 2025 17:47
@enjeck enjeck self-assigned this Aug 18, 2025
@enjeck
enjeck requested a review from blizzz as a code owner August 18, 2025 17:47
@enjeck enjeck added the 3. to review Waiting for reviews label Aug 18, 2025
@github-project-automation github-project-automation Bot moved this to 馃Л Planning evaluation (don't pick) in 馃摑 Productivity team Aug 18, 2025
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck

enjeck commented Aug 18, 2025

Copy link
Copy Markdown
Contributor Author

Here's how it works:
Screencast from 2025-08-18 18-44-52.webm

@silverkszlo

silverkszlo commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

The default for the column declaration in props does not seem to be correct. It says:

props: { 
  column: { 
    type: Object,
    default: () => {}, 
}

But apparently default: () => {} would return undefined. In order to return an empty object - if that's the goal - it should be default: () => ({}). At least that's what chatgpt, claude ai and copilot are suggesting :)

Also here: https://stackoverflow.com/a/58094369

@silverkszlo silverkszlo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and looks good in firefox and chromium! A nice next step would be to make it accessible and usable via keyboard.

@enjeck

enjeck commented Aug 19, 2025

Copy link
Copy Markdown
Contributor Author

The default for the column declaration in props does not seem to be correct. It says:

props: { 
  column: { 
    type: Object,
    default: () => {}, 
}

But apparently default: () => {} would return undefined. In order to return an empty object - if that's the goal - it should be default: () => ({}). At least that's what chatgpt, claude ai and copilot are suggesting :)

Also here: https://stackoverflow.com/a/58094369

We shouldn't even be defining the column and rowId props within the Cell file, since we already define within the mixin. We'll have to clean up. Maybe as part of #2009

@enjeck
enjeck merged commit 422f9b2 into main Aug 19, 2025
50 of 52 checks passed
@enjeck
enjeck deleted the feat/364-html branch August 19, 2025 08:49
@github-project-automation github-project-automation Bot moved this from 馃Л Planning evaluation (don't pick) to 鈽戯笍 Done in 馃摑 Productivity team Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants