1296 infinite loading when visiting non existent application

[silverkszlo]

This PR improves error handling when navigating to non-existent tables, views, or contexts in the Tables app.

Previously, accessing a non-existent resource (e.g. /view/999 or /context/999) would result in an unhandled exception (TypeError: undefined) and show only a loading spinner. This was confusing to users and cluttered the console with errors.

Changes

• Added proper error catching in Table.vue, View.vue, and Context.vue
• Display a user-friendly error message and icon when a resource is not found (404)
• Ensured layout is visually centered and styled consistently with other apps (e.g. Deck)

[enjeck]

Thanks! The failing component tests CI can be ignored. But will need to sign the commit message. In case you don't know how, https://github.com/nextcloud/server/wiki/How-to-sign-your-commits-using-PGP

[silverkszlo]

Thanks! The failing component tests CI can be ignored. But will need to sign the commit message. In case you don't know how, https://github.com/nextcloud/server/wiki/How-to-sign-your-commits-using-PGP

done, thank you!

[enjeck]

Thanks! I tested and it mostly works. Only problem is the browser console errors after visiting non-existent resources.
For applicatiions:

TypeError: Cannot read properties of undefined (reading 'name')
    at VueComponent.routing (main.js:22:2)
    at VueComponent.$route (main.js:22:2)
    at invokeWithErrorHandling (vue.runtime.esm.js:3033:30)
    at Watcher2.run (vue.runtime.esm.js:3550:21)
    at flushSchedulerQueue (vue.runtime.esm.js:4141:17)
    at Array.<anonymous> (vue.runtime.esm.js:3159:20)
    at flushCallbacks (vue.runtime.esm.js:3081:17)
logError @ vue.runtime.esm.js:3065

For views:

TypeError: Cannot read properties of undefined (reading 'title')
    at VueComponent.routing (main.js:22:2)
    at VueComponent.created (main.js:22:2)

This happens because we're trying to set the page title as seen in https://github.com/nextcloud/tables/blob/main/src/App.vue#L99 and https://github.com/nextcloud/tables/blob/main/src/App.vue#L108 but these do not exist

[silverkszlo]

Thanks! I tested and it mostly works. Only problem is the browser console errors after visiting non-existent resources. For applicatiions:

TypeError: Cannot read properties of undefined (reading 'name')
    at VueComponent.routing (main.js:22:2)
    at VueComponent.$route (main.js:22:2)
    at invokeWithErrorHandling (vue.runtime.esm.js:3033:30)
    at Watcher2.run (vue.runtime.esm.js:3550:21)
    at flushSchedulerQueue (vue.runtime.esm.js:4141:17)
    at Array.<anonymous> (vue.runtime.esm.js:3159:20)
    at flushCallbacks (vue.runtime.esm.js:3081:17)
logError @ vue.runtime.esm.js:3065

For views:

TypeError: Cannot read properties of undefined (reading 'title')
    at VueComponent.routing (main.js:22:2)
    at VueComponent.created (main.js:22:2)

This happens because we're trying to set the page title as seen in https://github.com/nextcloud/tables/blob/main/src/App.vue#L99 and https://github.com/nextcloud/tables/blob/main/src/App.vue#L108 but these do not exist

Thanks for pointing out the code lines! I have added default titles for those missing ressources. Do you think that makes sense?

[enjeck]

I have added default titles for those missing ressources. Do you think that makes sense?

I was thinking we would say something like "View/table/context not found". Since the title/name is a mandatory field and views/tables/contexts would always have them, if they exist. But I guess what you have is safer in case

[enjeck]

Was testing again and I noticed that when we're on the "error" page, the + buttons against "Tables" and "Applications" that let us create a new Table or Application do not work.
Issue might stem from https://github.com/nextcloud/tables/blob/main/src/modules/navigation/sections/Navigation.vue#L202, where we emit the events 🤔

[silverkszlo]

Was testing again and I noticed that when we're on the "error" page, the + buttons against "Tables" and "Applications" that let us create a new Table or Application do not work. Issue might stem from https://github.com/nextcloud/tables/blob/main/src/modules/navigation/sections/Navigation.vue#L202, where we emit the events 🤔

Okay I probably have fixed that by always rendering MainModals in Table and View for the Navigation to work correctly. What do you think?

[enjeck]

Hmm, the behavior for the non-exisitng application changed? I no longer see an "error page". It just redirects to the homepage. Is that intentional? 🤔

[enjeck]

Hmm, the behavior for the non-exisitng application changed? I no longer see an "error page". It just redirects to the homepage. Is that intentional? 🤔

This still happens for me :|

[enjeck]

When I'm on a table and I delete it, the previous behavior was to redirect to the homepage (which is good). Now, we are stuck on an infinite loading screen.
Views and Apps, however, work fine

[enjeck]

Thanks. I tested and now works. Just a few comments:

[enjeck]

Cool, thx