feat: Inline editing - Rich text - #1976
Conversation
8efaf7e to
6a98023
Compare
|
@marcoambrosini I'm not sure how to handle cancel and save actions here. With the other input types, we use the Enter key to save (or clicking outside of the input) and Escape key to cancel. We can't use Enter here since the rich text editor treats it as a new line, as it should. 馃 |
Since clicking outside saves it anyway, it makes sense to use the enter key for only newlines. I just checked Airtable and they do the same thing (enter creates a new line and clicking outside saves). Airtable also additionally uses Esc also for saving, which makes no sense to me, so we can stick to Esc always cancelling, clicking outside always saving, and enter key saving if column type is not rich text 馃憤 |
cb9049e to
551979d
Compare
|
Here's how it works: Since the menubar has some dropdowns that might not fit within the row cell, I hide the menubar: |
|
I found two problems:
test.mp4 |
551979d to
dd28b31
Compare
I just checked and even though it forces you to go to edit mode, you can still copy from there |
@AIlkiv Thanks for testing. Should be fixed now? |
3e708c1 to
21b76e8
Compare
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
c6ebab9 to
594b45d
Compare

Part of #364
Supports inline editing for the rich text editor