Skip to content

feat: Inline editing - Rich text - #1976

Merged
enjeck merged 6 commits into
mainfrom
feat/364-editor
Aug 19, 2025
Merged

feat: Inline editing - Rich text#1976
enjeck merged 6 commits into
mainfrom
feat/364-editor

Conversation

@enjeck

@enjeck enjeck commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

Part of #364

Supports inline editing for the rich text editor

@enjeck enjeck self-assigned this Aug 5, 2025
@enjeck enjeck added enhancement New feature or request 2. developing Work in progress labels Aug 5, 2025
@github-project-automation github-project-automation Bot moved this to 馃Л Planning evaluation (don't pick) in 馃摑 Productivity team Aug 5, 2025
@enjeck enjeck mentioned this pull request Aug 5, 2025
17 tasks
Base automatically changed from feat/364 to main August 5, 2025 07:29
@enjeck

enjeck commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

@marcoambrosini I'm not sure how to handle cancel and save actions here. With the other input types, we use the Enter key to save (or clicking outside of the input) and Escape key to cancel. We can't use Enter here since the rich text editor treats it as a new line, as it should. 馃

@nimishavijay

Copy link
Copy Markdown
Member

I'm not sure how to handle cancel and save actions here. With the other input types, we use the Enter key to save (or clicking outside of the input) and Escape key to cancel. We can't use Enter here since the rich text editor treats it as a new line, as it should. 馃

Since clicking outside saves it anyway, it makes sense to use the enter key for only newlines. I just checked Airtable and they do the same thing (enter creates a new line and clicking outside saves). Airtable also additionally uses Esc also for saving, which makes no sense to me, so we can stick to Esc always cancelling, clicking outside always saving, and enter key saving if column type is not rich text 馃憤

@enjeck
enjeck marked this pull request as ready for review August 15, 2025 07:24
@enjeck
enjeck requested a review from blizzz as a code owner August 15, 2025 07:24
@enjeck

enjeck commented Aug 15, 2025

Copy link
Copy Markdown
Contributor Author

Here's how it works:
Screencast from 2025-08-15 08-13-33.webm

Since the menubar has some dropdowns that might not fit within the row cell, I hide the menubar:
Screenshot from 2025-08-15 06-29-42

@AIlkiv

AIlkiv commented Aug 16, 2025

Copy link
Copy Markdown
Contributor

I found two problems:

  1. Interaction with interactive elements in Text (link/picture/video) does not work.
  2. I cannot select text to copy.
test.mp4

@enjeck

enjeck commented Aug 17, 2025

Copy link
Copy Markdown
Contributor Author

2. I cannot select text to copy.

I just checked and even though it forces you to go to edit mode, you can still copy from there

@enjeck

enjeck commented Aug 17, 2025

Copy link
Copy Markdown
Contributor Author

I found two problems:

  1. Interaction with interactive elements in Text (link/picture/video) does not work.

@AIlkiv Thanks for testing. Should be fixed now?

Comment thread src/shared/components/ncTable/partials/RichEditor.vue Outdated
Comment thread src/shared/components/ncTable/partials/RichEditor.vue Outdated
Comment thread src/shared/components/ncTable/partials/RichEditor.vue
enjeck added 5 commits August 19, 2025 09:53
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck
enjeck merged commit 7da7488 into main Aug 19, 2025
48 of 52 checks passed
@enjeck
enjeck deleted the feat/364-editor branch August 19, 2025 09:24
@github-project-automation github-project-automation Bot moved this from 馃Л Planning evaluation (don't pick) to 鈽戯笍 Done in 馃摑 Productivity team Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants