feat: Inline editing - Selection - #1975
Conversation
5318dec to
77cb2cb
Compare
77cb2cb to
5de184d
Compare
|
Here's how it works: |
There was a problem hiding this comment.
Looks good except for the broken border in the dropdown, that would be something we have to fix.
A nice-to-have: in view mode show the multiple options styled as user bubbles, similar to how they are shown in the dropdown. Currently they are shown as bullet list items which looks very different. Can also be in a follow up
Yes, would have to be done as a follow up since this is unrelated to inline editing itself as the view mode has always looked like this |
58e85a6 to
d939da7
Compare
|
|
||
| initEditValue() { | ||
| if (this.value !== null) { | ||
| this.editValue = this.getOptionObject(parseInt(this.value)) |
There was a problem hiding this comment.
is parseInt here necessary if value is already a Number (in props)?
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
…ction components Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
c37d7c1 to
c7ddc9f
Compare
Part of #364
Supports inline editing for the Selection and MultiSelection column types
TODO