feat: Inline editing - Datetime - #1974
Merged
Merged
Conversation
github-project-automation
Bot
moved this to 馃Л Planning evaluation (don't pick)
in 馃摑 Productivity team
Contributor
Author
|
Here's how it looks: |
marcoambrosini
previously requested changes
Aug 6, 2025
marcoambrosini
left a comment
marcoambrosini
left a comment
Member
There was a problem hiding this comment.
We should remove the "select a date" heading here. The fully accessible view with labels is always present in the row-editing-dialog. So it's ok if we do not have labels in inline editing.
silverkszlo
reviewed
Aug 13, 2025
silverkszlo
reviewed
Aug 13, 2025
enjeck
force-pushed
the
feat/364-date
branch
2 times, most recently
from
August 14, 2025 03:10
9fa7258 to
8e49216
Compare
Contributor
Author
|
@marcoambrosini It now looks like so: |
silverkszlo
reviewed
Aug 14, 2025
silverkszlo
reviewed
Aug 14, 2025
silverkszlo
reviewed
Aug 14, 2025
silverkszlo
reviewed
Aug 14, 2025
silverkszlo
left a comment
silverkszlo
left a comment
Contributor
There was a problem hiding this comment.
Looks very cool! I have tested it in Firefox and Chromium and all in all it works nicely. I have only suggested minor changes for more accessibility and removing potentially obsolete code.
enjeck
force-pushed
the
feat/364-date
branch
2 times, most recently
from
August 18, 2025 15:30
8c1bbb0 to
5bc74af
Compare
silverkszlo
approved these changes
Aug 18, 2025
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
github-project-automation
Bot
moved this from 馃Л Planning evaluation (don't pick)
to 鈽戯笍 Done
in 馃摑 Productivity team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #364
Adds support for inline editing for Date, Time and Datetime column types