feat: Inline editing - Stars - #1973
Merged
Merged
Conversation
github-project-automation
Bot
moved this to 馃Л Planning evaluation (don't pick)
in 馃摑 Productivity team
Contributor
Author
|
Looks like so: |
marcoambrosini
previously requested changes
Aug 6, 2025
marcoambrosini
left a comment
marcoambrosini
left a comment
Member
There was a problem hiding this comment.
Hi @enjeck, I think it would be better to allow clicking on the stars directly instead of having a plus and minus buttons to the sides. Could you change that?
enjeck
force-pushed
the
feat/364-stars
branch
2 times, most recently
from
August 14, 2025 03:51
b327409 to
f442d7b
Compare
silverkszlo
reviewed
Aug 18, 2025
silverkszlo
reviewed
Aug 18, 2025
silverkszlo
reviewed
Aug 18, 2025
silverkszlo
reviewed
Aug 18, 2025
silverkszlo
left a comment
silverkszlo
left a comment
Contributor
There was a problem hiding this comment.
Looks nice and works in Firefox and Chromium!
- I can only edit existing star rating fields inline but not create a new one inline. Is that expected behavior?
- Possible accessibility edit for later: right now I can only edit it with a mouse and not the keyboard
Contributor
Author
If a row is created empty, it's automatially given 0 stars that you can edit. Not sure what you mean by "creating a new one"? |
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Contributor
Yeah, apparently I had forgotten to add a row, nevermind |
silverkszlo
approved these changes
Aug 18, 2025
github-project-automation
Bot
moved this from 馃Л Planning evaluation (don't pick)
to 鈽戯笍 Done
in 馃摑 Productivity team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #364
Supports inline editing for TableCellStars