fix: avoid double app password check - #1135
Merged
Merged
Conversation
The server already tests the password to be an app password and passes that info through the event. The login listener has an early exit. Yet this app also tested the shape of the password, which can lead to false negatives. Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
DerDreschner
approved these changes
Aug 31, 2026
This was referenced Aug 31, 2026
Member
Author
|
/backport to stable35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server already tests the password to be an app password and passes that info through the event. The login listener has an early exit. Yet this app also tested the shape of the password, which can lead to false negatives.
🤖 AI (if applicable)