chore(psalm): remove obsolete UndefinedDocblockClass suppressions - #1134
Merged
Conversation
NC36's OCP retyped OCP\DB\ISchemaWrapper to return OCP\DB\ITable instead of Doctrine\DBAL\Schema\Table, so the migrations no longer resolve to any undefined Doctrine DBAL class. The whole UndefinedDocblockClass handler now suppresses nothing and Psalm reports it as UnusedIssueHandlerSuppression. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
ChristophWurst
force-pushed
the
fix/psalm-stale-dbal-suppression
branch
from
August 26, 2026 08:39
dbcc940 to
67f4faa
Compare
ChristophWurst
changed the title
php-available resolves to PHP 8.5 for Nextcloud 36, where Psalm 6.16.1 crashes while stringifying rubix/ml's `const OUTLIER_VALUE = NAN` (PHP 8.5 warns on NAN-to-string coercion and Psalm rethrows the warning). Running on php-min keeps analysis on the version psalm.xml already targets. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
DerDreschner
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the red CI of #1132.
NC36's OCP no longer references Doctrine\DBAL\Driver\Statement in its docblocks, so the UndefinedDocblockClass suppression for it is never hit and Psalm reports it as an UnusedIssueHandlerSuppression.
Assisted-by: ClaudeCode:claude-opus-4-8
🤖 AI (if applicable)