[stable34] fix(call): guard against a missing local state broadcaster when leaving a call - #19260
Merged
Conversation
…ng a call The "beforeLeaveCall" handler assumes that "beforeJoinCall" ran before it and left a broadcaster behind. The variable is null whenever the call was not joined in this page session, and it is set back to null after the first leave. leaveRoom() calls leaveCurrentCall() unconditionally, so leaving or switching a conversation reaches the handler either way and raises "Cannot read properties of null (reading 'destroy')". The exception is raised inside the promise chain of leaveCall(), so it aborts whatever the caller was doing, for example the switchto handling that moves participants to another conversation when a one-to-one conversation is extended into a group conversation. Signed-off-by: Baki Burak Öğün <63836730+bakiburakogun@users.noreply.github.com>
backportbot
Bot
added
bug
feature: frontend 🖌️
Antreesy
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #19083