Skip to content

[stable33] fix(sip): Correct restrict SIP creation #19241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Sep 3, 2026
+39 −1
Merged

[stable33] fix(sip): Correct restrict SIP creation #19241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/Controller/RoomController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,6 +794,14 @@ public function createRoom(
$password = '';
}

// Enabling SIP dial-in is restricted to the configured groups, so requesting
// it at creation time requires the same permission as toggling it later on.
if ($sipEnabled !== Webinary::SIP_DISABLED
&& (!$this->talkConfig->isSIPConfigured()
|| !$this->talkConfig->canUserEnableSIP($user))) {
return new DataResponse(['error' => CreationException::REASON_SIP_ENABLED], Http::STATUS_FORBIDDEN);
}

$invitationList = $this->invitationService->validateInvitations($participants, $user);
if ($invitationList->hasInvalidInvitations() && !$invitationList->hasValidInvitations()) {
// FIXME add the list of failed invitations?
Expand Down
32 changes: 31 additions & 1 deletion tests/integration/features/conversation-1/create.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,40 @@ Feature: conversation-1/create
| room | 3 | 1 | 1 | GREATER_THAN_ZERO |

Scenario: Enable SIP during creation
Given the following "spreed" app config is set
Given group "group1" exists
And user "participant1" is member of group "group1"
And the following "spreed" app config is set
| sip_bridge_dialin_info | +49-1234-567890 |
| sip_bridge_shared_secret | 1234567890abcdef |
| sip_bridge_groups | ["group1"] |
Given user "participant1" creates room "room" (v4)
| roomType | 3 |
| roomName | room |
| sipEnabled | 1 |
Then user "participant1" is participant of the following rooms (v4)
| id | type | participantType | sipEnabled |
| room | 3 | 1 | 1 |

Scenario: Enable SIP during creation without being allowed to enable SIP
Given group "group1" exists
And the following "spreed" app config is set
| sip_bridge_dialin_info | +49-1234-567890 |
| sip_bridge_shared_secret | 1234567890abcdef |
| sip_bridge_groups | ["group1"] |
When user "participant1" creates room "room" with 403 (v4)
| roomType | 3 |
| roomName | room |
| sipEnabled | 1 |
And user "participant1" creates room "room" with 403 (v4)
| roomType | 3 |
| roomName | room |
| sipEnabled | 2 |
Then user "participant1" is participant of the following rooms (v4)

Scenario: Enable SIP during creation while not being restricted by groups
Given the following "spreed" app config is set
| sip_bridge_dialin_info | +49-1234-567890 |
| sip_bridge_shared_secret | 1234567890abcdef |
Given user "participant1" creates room "room" (v4)
| roomType | 3 |
| roomName | room |
Expand Down
Loading