[stable34] fix(FilePreview): sanitize file name - #19229
Merged
Merged
Conversation
backportbot
Bot
added
bug
feature: frontend 🖌️
- only used in SharedItems.vue together with rowLayout, so redundant Assisted-by: ClaudeCode:claude-sonnet-4-6 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- bidi-control unicode characters are not visible in browser, but causing confusion with inline rendering under certain conditions - for rendered DOM: align with Files app, render file extension in separate tag, isolate unicode-bidi - for titles and aria-labels: replace with underscore (same as downloaded file name) Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
backport/19228/stable34
branch
from
September 2, 2026 16:04
a522d8e to
7d066d4
Compare
Contributor
|
/backport! to stable33 |
Antreesy
marked this pull request as ready for review
September 2, 2026 16:05
This comment was marked as resolved.
This comment was marked as resolved.
Antreesy
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #19228
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.