chore(config): refactor session-ping-limit setting to valid ConfigLexicon name pattern with underscores - #19223
Conversation
sudormant
added
feature: settings ⚙️
| new Entry(Config::CREATE_SAMPLES, ValueType::BOOL, true, definition: 'Create sample conversations (the content can be overwritten by providing files in a provided `samples_directory` app config)'), | ||
| new Entry(Config::MATTERBRIDGE_ENABLED, ValueType::BOOL, false, definition: 'Whether the Matterbridge integration is enabled and can be configured'), | ||
| new Entry(Config::DELETE_ONE_TO_ONE_CONVERSATIONS, ValueType::BOOL, false, definition: 'Whether one-to-one conversations can be left by either participant or should be deleted when one participant leaves'), | ||
| new Entry(Config::SESSION_PING_LIMIT, ValueType::INT, 200, definition: 'Number of sessions the HPB can ping in a single request'), |
There was a problem hiding this comment.
Also rename option here and CI is failing
|
Needs a rebase |
…icon name pattern with underscores Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
b7a8c5a to
419a454
Compare
rebased, but composer test:unit is still failing: There were 4 errors:
/var/www/html/apps-extra/spreed/lib/Capabilities.php:335
/var/www/html/apps-extra/spreed/lib/Capabilities.php:335
/var/www/html/apps-extra/spreed/lib/Capabilities.php:335
/var/www/html/apps-extra/spreed/lib/Capabilities.php:335 appConfig doesn't return default value or 0, even setting $this->appConfig->setAppValueInt(Config::SESSION_PING_LIMIT, 200); right before the test doesn't change the test result. Happens with some refactored settings to appConfig, but not others. haven't found the root issue quite yet. |
2 participants
🏁 Checklist
docs/has been updated or is not required