Skip to content

feat(conversation): adjust scroll to unread mentions - #19100

Merged
Antreesy merged 1 commit into
mainfrom
fix/noid/fix-unread-mentions-scroll
Aug 26, 2026
Merged

feat(conversation): adjust scroll to unread mentions#19100
Antreesy merged 1 commit into
mainfrom
fix/noid/fix-unread-mentions-scroll

Conversation

@Antreesy

Copy link
Copy Markdown
Contributor

β˜‘οΈ Resolves

  • Fix scroll to unread mention
    • previous 'unreadMentionIndices' was accounting only for sortedConversationsList, but we render ConversationsListVirtual#listItems and should compute indexes directly from it

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

πŸ–ŒοΈ UI Checklist

πŸ–ΌοΈ Screenshots / Screencasts

🏚️ Before

unreadm-before.mp4

🏑 After

unreadm-after.mp4

🚧 Tasks

  • ...

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • πŸ–ŒοΈ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • πŸ“— User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

- previous 'unreadMentionIndices' was accounting only for sortedConversationsList, but we render ConversationsListVirtual#listItems and should compute indexes directly from it

Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the β›… Next Beta/RC (35) milestone Aug 26, 2026
@Antreesy
Antreesy requested a review from DorraJaouad August 26, 2026 10:16
@Antreesy Antreesy self-assigned this Aug 26, 2026
@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Aug 26, 2026
@Antreesy

Copy link
Copy Markdown
Contributor Author

/backport to stable35

@Antreesy

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@Antreesy
Antreesy merged commit 718ecfc into main Aug 26, 2026
54 checks passed
@Antreesy
Antreesy deleted the fix/noid/fix-unread-mentions-scroll branch August 26, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants