feat(upload): show file size on upload - #19045
Merged
Merged
Conversation
Antreesy
added
design
enhancement
feature: frontend 🖌️
Antreesy
force-pushed
the
fix/noid/file-upload-show-size
branch
from
August 24, 2026 15:53
b60fc9c to
984ea0a
Compare
Antreesy
commented
Aug 24, 2026
| inset-inline-end: var(--default-grid-baseline); | ||
| padding: calc(0.5 * var(--default-grid-baseline)) var(--default-grid-baseline); | ||
| border-radius: var(--border-radius); | ||
| background-color: rgba(var(--color-main-background-rgb), 0.5); |
Contributor
Author
There was a problem hiding this comment.
Decreased opacity from 0.85 to 0.5 after alignment with design team
Details
Same as on old screenshots, just less contrast
Contributor
There was a problem hiding this comment.
This is not accessible due to low contrast.
Can we have it under the image?
Contributor
Author
There was a problem hiding this comment.
I'd rather increase opacity value back to the high one...
Staged files have either a preview or mimeicon+name to be identified, we can't take any space from the name area
Contributor
Author
There was a problem hiding this comment.
It's already 13px, we can't / shouldn't go lower
Will revert opacity back to 0.85, again aligned with @nimishavijay
Contributor
Author
There was a problem hiding this comment.
Actually taking a sweet midle of 0.7 (pass WCAG AAA, less prominent):
| 0.5 | 0.7 (minimum to pass) | 0.85 |
|---|---|---|
 |
 |
 |
DorraJaouad
approved these changes
Aug 25, 2026
Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/noid/file-upload-show-size
branch
from
August 25, 2026 11:18
984ea0a to
6f22907
Compare
Antreesy
enabled auto-merge
August 25, 2026 11:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
AI (if applicable)
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist