Skip to content

fix: pass Referer header to OpenStreetMap - #19033

Merged
Antreesy merged 2 commits into
mainfrom
fix/noid/map-referer-firefox
Aug 20, 2026
Merged

fix: pass Referer header to OpenStreetMap#19033
Antreesy merged 2 commits into
mainfrom
fix/noid/map-referer-firefox

Conversation

@Antreesy

@Antreesy Antreesy commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

☑️ Resolves

  • Fix map rendering on Firefox (commit 1)
    • HTTP Referer header was required to be sent with image requests
    • Cache-Control: no-cache shoudl also not be sent
    • Without it, OSM host returns malformed image tiles
  • Refactor to typescript + script setup (commit 2)

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
2026-08-19_11h00_34 2026-08-19_10h59_50
2026-08-19_10h57_31 2026-08-19_10h58_09

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the ⛅ Next Beta/RC (35) milestone Aug 19, 2026
@Antreesy
Antreesy requested review from DorraJaouad and ShGKme August 19, 2026 09:53
@Antreesy Antreesy self-assigned this Aug 19, 2026
@Antreesy Antreesy added bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client AI assisted This PR contains AI-assisted commits labels Aug 19, 2026
ShGKme
ShGKme reviewed Aug 19, 2026
View reviewed changes
Comment thread src/components/MessagesList/MessagesGroup/Message/MessagePart/LocationCard.vue
@Antreesy Antreesy changed the title Fix/noid/map referer firefox fix: pass Referer header to OpenStreetMap Aug 19, 2026
@Antreesy
fix(LocationCard): add referer to image tiles requests
2121d5f 
Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Antreesy force-pushed the fix/noid/map-referer-firefox branch from cc9320f to a035b14 Compare August 20, 2026 09:24
@Antreesy
Antreesy requested a review from ShGKme August 20, 2026 09:24
@Antreesy
Antreesy force-pushed the fix/noid/map-referer-firefox branch from a035b14 to 570e5f7 Compare August 20, 2026 14:14
@Antreesy

Antreesy commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Invalid prop: type check failed for prop "longitude". Expected Number with value -74.17913836543973, got String with value "-74.17913836543973"

Updated prop types for latitude / longitude to String, as sent by server.
vue-leaflet expects number, cast to Number() for center computed

@Antreesy
refactor(LocationCard): migrate to script setup
2e0f64d 
Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Antreesy force-pushed the fix/noid/map-referer-firefox branch from 570e5f7 to 2e0f64d Compare August 20, 2026 14:20
@Antreesy
Antreesy merged commit 88af98c into main Aug 20, 2026
53 of 54 checks passed
@Antreesy
Antreesy deleted the fix/noid/map-referer-firefox branch August 20, 2026 14:30
@Antreesy

Antreesy commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@Antreesy

Antreesy commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable33

@backportbot backportbot Bot mentioned this pull request Aug 20, 2026
Merged
@backportbot backportbot Bot mentioned this pull request Aug 20, 2026
Merged
@Antreesy

Antreesy commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable32

@backportbot backportbot Bot mentioned this pull request Aug 20, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKme ShGKme ShGKme approved these changes
@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels

AI assisted This PR contains AI-assisted commits bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v25.0.0-rc.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Antreesy @ShGKme @nickvergessen