Skip to content

refactor(AudioPlayer): inject nextMessageId value - #19019

Merged
Antreesy merged 2 commits into
mainfrom
fix/noid/file-p1-audio-player
Aug 17, 2026
Merged

refactor(AudioPlayer): inject nextMessageId value#19019
Antreesy merged 2 commits into
mainfrom
fix/noid/file-p1-audio-player

Conversation

@Antreesy

Copy link
Copy Markdown
Contributor

β˜‘οΈ Resolves

  • Skip prop-drilling through FilePreview
  • Pre-requisite for further refactoring
  • Resolve warning for temporary voice messages

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

πŸ–ŒοΈ UI Checklist

πŸ–ΌοΈ Screenshots / Screencasts

No visual changes

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • πŸ–ŒοΈ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • πŸ“— User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Stack created with GitHub Stacks CLI β€’ Give Feedback πŸ’¬

- FilePreview does not need it
- prep for extracting richParameters

Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
 - filePreviewElement and filePreviewBinding should return consistent results (warning noticed for temp voice message)

Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Aug 17, 2026
@Antreesy
Antreesy requested a review from DorraJaouad August 17, 2026 16:37
@Antreesy Antreesy self-assigned this Aug 17, 2026
@Antreesy Antreesy added this to the β›… Next Beta/RC (35) milestone Aug 17, 2026
@Antreesy
Antreesy merged commit 4f62498 into main Aug 17, 2026
54 checks passed
@Antreesy
Antreesy deleted the fix/noid/file-p1-audio-player branch August 17, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI assisted This PR contains AI-assisted commits feature: frontend πŸ–ŒοΈ "Web UI" client feature: upload & shares & voice πŸ“€πŸŽ™οΈ Sharing files into a chat and audio recordings technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants