Skip to content

fix(virtual-bg): stop effect when device checker is not in use - #18205

Merged
nickvergessen merged 1 commit into
mainfrom
fix/noid/disabled-bg-blur
Jun 11, 2026
Merged

fix(virtual-bg): stop effect when device checker is not in use#18205
nickvergessen merged 1 commit into
mainfrom
fix/noid/disabled-bg-blur

Conversation

@Antreesy

@Antreesy Antreesy commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

☑️ Resolves

  • While checking devices:
    • effect lives as long as dialog is opened (no parallel inference during call)

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Running the same pattern:

  1. Camera off, blur off
  2. Camera on, blur off
  3. Camera on, blur on
  4. Camera off, blur on (fix)
🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the ⛅ Next Major (35) milestone Jun 3, 2026
@Antreesy
Antreesy requested review from DorraJaouad and danxuliu June 3, 2026 09:33
@Antreesy Antreesy self-assigned this Jun 3, 2026
@Antreesy Antreesy added bug feature: frontend 🖌️ "Web UI" client feature: call 📹 Voice and video calls labels Jun 3, 2026
@Antreesy

Antreesy commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@Antreesy

Antreesy commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable33

@Antreesy

Antreesy commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable32

@Antreesy
Antreesy force-pushed the fix/noid/disabled-bg-blur branch from 9e9433e to 8d23b71 Compare June 3, 2026 14:45
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Antreesy force-pushed the fix/noid/disabled-bg-blur branch from 8d23b71 to 102ef57 Compare June 10, 2026 14:05
@Antreesy Antreesy changed the title fix(virtual-bg): stop effect when not in use fix(virtual-bg): stop effect when device checker is not in use Jun 10, 2026
@nickvergessen
nickvergessen merged commit 8da7de7 into main Jun 11, 2026
53 checks passed
@nickvergessen
nickvergessen deleted the fix/noid/disabled-bg-blur branch June 11, 2026 13:29
@backportbot

backportbot Bot commented Jun 11, 2026

Copy link
Copy Markdown

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/18205/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 102ef57e

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/18205/stable32

Error: Failed to check for changes with origin/stable32: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants