Skip to content

fix: voice room followups - #18112

Merged
DorraJaouad merged 3 commits into
mainfrom
fix/18069/voice-room-followups
Jun 5, 2026
Merged

fix: voice room followups#18112
DorraJaouad merged 3 commits into
mainfrom
fix/18069/voice-room-followups

Conversation

@DorraJaouad

@DorraJaouad DorraJaouad commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

☑️ Resolves

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad
DorraJaouad requested a review from Antreesy May 26, 2026 11:12
@DorraJaouad DorraJaouad self-assigned this May 26, 2026
@DorraJaouad
DorraJaouad force-pushed the fix/18069/voice-room-followups branch from 40a9e4b to 680d003 Compare June 3, 2026 08:58
@DorraJaouad
DorraJaouad marked this pull request as ready for review June 3, 2026 08:58
Antreesy
Antreesy reviewed Jun 3, 2026
View reviewed changes
Comment thread src/components/LeftSidebar/ConversationsList/ConversationItem.vue Outdated
Comment thread src/App.vue Outdated
Comment thread src/App.vue Outdated
@DorraJaouad
DorraJaouad force-pushed the fix/18069/voice-room-followups branch from 680d003 to 3025e19 Compare June 4, 2026 19:34
Antreesy
Antreesy reviewed Jun 5, 2026
View reviewed changes

@Antreesy Antreesy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works =)

Comment thread src/components/LeftSidebar/ConversationsList/ConversationItem.vue Outdated
Comment thread src/App.vue
Comment thread src/views/MainView.vue Outdated
Comment thread src/views/MainView.vue
Comment thread src/components/MediaSettings/MediaSettings.vue Outdated
Antreesy
Antreesy approved these changes Jun 5, 2026
View reviewed changes

@Antreesy Antreesy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good)

Comment thread src/views/MainView.vue Outdated
Comment thread src/components/MediaSettings/MediaSettings.vue Outdated
@DorraJaouad
fix: show icon type when conversations list is compacted and hide the…
9b84611 
… last message respecting API visibility

Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
fix: respect global settings of obligation to show media settings for…
f49ee98 
… voice rooms.

Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
fix(sound): don't play waiting sound in voice rooms
eb8ff43 
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
DorraJaouad force-pushed the fix/18069/voice-room-followups branch from 788de96 to eb8ff43 Compare June 5, 2026 14:27
@DorraJaouad
DorraJaouad merged commit 41f4d14 into main Jun 5, 2026
53 checks passed
@DorraJaouad
DorraJaouad deleted the fix/18069/voice-room-followups branch June 5, 2026 15:39
@DorraJaouad

DorraJaouad commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@backportbot backportbot Bot mentioned this pull request Jun 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Voice room usability follow-ups

2 participants

@DorraJaouad @Antreesy