Skip to content

fix: join call immediately with #direct-call param - #17498

Merged
Antreesy merged 5 commits into
mainfrom
fix/17471/respect-direct-call
Apr 24, 2026
Merged

fix: join call immediately with #direct-call param#17498
Antreesy merged 5 commits into
mainfrom
fix/17471/respect-direct-call

Conversation

@Antreesy

@Antreesy Antreesy commented Mar 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

☑️ Resolves

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before image

🚧 Tasks

  • FIXME need to wait for join conversation

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🏖️ Next Major (34) milestone Mar 26, 2026
@Antreesy Antreesy self-assigned this Mar 26, 2026
@Antreesy Antreesy added feature: frontend 🖌️ "Web UI" client feature: call 📹 Voice and video calls labels Mar 26, 2026
@Antreesy Antreesy changed the title Fix/17471/respect direct call fix: join call immediately with #direct-call param Mar 26, 2026
@Antreesy
Antreesy force-pushed the fix/17471/respect-direct-call branch from 44658f7 to e85c254 Compare March 27, 2026 15:41
@Antreesy
Antreesy marked this pull request as ready for review March 27, 2026 15:41
@Antreesy
Antreesy requested review from DorraJaouad and ShGKme March 27, 2026 15:41
DorraJaouad
DorraJaouad reviewed Mar 30, 2026
View reviewed changes

@DorraJaouad DorraJaouad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not bad

Comment thread src/views/MainView.vue Outdated
@Antreesy
Antreesy force-pushed the fix/17471/respect-direct-call branch from e85c254 to 940892d Compare April 2, 2026 08:57
@Antreesy
Antreesy requested a review from DorraJaouad April 2, 2026 08:58
@usselite

usselite commented Apr 9, 2026

Copy link
Copy Markdown
Member

Looking good @Antreesy. If I may suggest one thing, would it be possible to predefine the type of 'call' with #direct-call parameter? E.g. start audio only or with video etc?

@Antreesy

Antreesy commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

would it be possible to predefine the type of 'call' with #direct-call parameter? E.g. start audio only or with video etc?

That's not the goal of this PR, more like fitting under the follow-up #17574

@Antreesy
Antreesy force-pushed the fix/17471/respect-direct-call branch 2 times, most recently from 3241bce to a174839 Compare April 13, 2026 12:05
@Antreesy Antreesy mentioned this pull request Apr 15, 2026
Merged
11 tasks
@Antreesy
Antreesy force-pushed the fix/17471/respect-direct-call branch from a174839 to 5f0d030 Compare April 17, 2026 10:16
DorraJaouad
DorraJaouad approved these changes Apr 23, 2026
View reviewed changes

@DorraJaouad DorraJaouad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested
One Note: can you please add skip the handling for non-callable rooms ( like note to self and changelog) ?

@nickvergessen

nickvergessen commented Apr 24, 2026

Copy link
Copy Markdown
Member

Needs a rebase and then we merge it?

Antreesy added 3 commits April 24, 2026 13:31
@Antreesy
fix: extract joinCall logic from CallButton component
d466a73 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: reuse logic in MainView for #direct-call feature
8c977ee 
- add additional check for the need to show media settings
- add additional check for the need to wait for joining conversation

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: add media options for joinCall
7d556bc 
- join direct calls rooms with video off
- join when 'Skip device preview' with video off

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Antreesy force-pushed the fix/17471/respect-direct-call branch from 5f0d030 to 60f94c3 Compare April 24, 2026 11:41
Antreesy added 2 commits April 24, 2026 13:47
@Antreesy
fix: add watcher for joined-conversation to correctly handle joining …
552da86 
…flow

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: break from direct-call handling in note-to-self and changelog rooms
67b4277 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Antreesy force-pushed the fix/17471/respect-direct-call branch from 60f94c3 to 67b4277 Compare April 24, 2026 11:48
@Antreesy

Antreesy commented Apr 24, 2026

Copy link
Copy Markdown
Contributor Author

can you please add skip the handling for note to self and changelog?

Addressed in separate commit. One-liner, so not waiting for re-review

Needs a rebase and then we merge it?

Done, conflicts dropped as already modified in main, no other changes

@Antreesy
Antreesy merged commit d476f07 into main Apr 24, 2026
53 checks passed
@Antreesy
Antreesy deleted the fix/17471/respect-direct-call branch April 24, 2026 11:50
@Antreesy Antreesy mentioned this pull request Jul 3, 2026
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes
@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels

feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v24.0.0-beta.1

4 participants

@Antreesy @usselite @nickvergessen @DorraJaouad