Skip to content

feat(hint): Recording, Transcript, SIP - #17490

Merged
nickvergessen merged 3 commits into
mainfrom
feat/17148/feature-hints
Mar 26, 2026
Merged

feat(hint): Recording, Transcript, SIP#17490
nickvergessen merged 3 commits into
mainfrom
feat/17148/feature-hints

Conversation

@nickvergessen

@nickvergessen nickvergessen commented Mar 25, 2026

Copy link
Copy Markdown
Member

☑️ Resolves

Feat Screenshot Screenshot2
Recording grafik grafik
Transcript Bildschirmfoto vom 2026-03-25 17-57-31 grafik
Translation Bildschirmfoto vom 2026-03-25 17-56-57
SIP calls Bildschirmfoto vom 2026-03-25 18-08-19 grafik

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@miaulalala miaulalala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I'd leave the submenu button on the live transcription feature if possible to also see the live translation feature missing hint even if the live transcription isn't on

@Antreesy

Copy link
Copy Markdown
Contributor

possible to also see the live translation feature missing hint even if the live transcription isn't on

translation is co-dependent, so I wouldn't overengineer it. In worst case admin will make a second round of installing and configuring?

@miaulalala

Copy link
Copy Markdown
Contributor

possible to also see the live translation feature missing hint even if the live transcription isn't on

translation is co-dependent, so I wouldn't overengineer it. In worst case admin will make a second round of installing and configuring?

Fair enough, that makes sense.

Comment thread src/components/CallView/BottomBar.vue
Comment thread src/components/CallView/BottomBar.vue
Comment thread src/components/CallView/BottomBar.vue Outdated

@miaulalala miaulalala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@nickvergessen
nickvergessen requested a review from Antreesy March 26, 2026 14:40

@Antreesy Antreesy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit dirty with all duplications, but otherwise ok

Comment thread src/components/RightSidebar/Participants/ParticipantsTab.vue
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessen force-pushed the feat/17148/feature-hints branch from 6dddf0d to 2fb49b7 Compare March 26, 2026 16:00
@nickvergessen
nickvergessen enabled auto-merge March 26, 2026 16:00
@nickvergessen
nickvergessen merged commit 41ddbaa into main Mar 26, 2026
79 checks passed
@nickvergessen
nickvergessen deleted the feat/17148/feature-hints branch March 26, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants