feat(email): Allow email guests without public link - #13609
Merged
nickvergessen merged 6 commits intoMay 13, 2026
Conversation
nickvergessen
added
2. developing
enhancement
feature: api 🛠️
nickvergessen
marked this pull request as draft
October 23, 2024 04:59
6 tasks
nickvergessen
force-pushed
the
feat/noid/allow-email-guests-without-public-link
branch
from
February 19, 2025 12:38
eae90dd to
2c97322
Compare
nickvergessen
force-pushed
the
feat/noid/allow-email-guests-without-public-link
branch
from
March 21, 2026 14:15
2c97322 to
4cdf950
Compare
nickvergessen
force-pushed
the
feat/noid/allow-email-guests-without-public-link
branch
from
May 8, 2026 19:42
4cdf950 to
ac2fac9
Compare
Member
Author
|
Currently reloading as an email user seems to break in the frontend as the context request is done before joining the room finished: 
I assume this might be from the recent changes to allow chatting even when signaling does not work or something. Posting a message (selected line) afterwards fixes the problem and shows all the chat messages. |
nickvergessen
force-pushed
the
feat/noid/allow-email-guests-without-public-link
branch
from
May 11, 2026 22:01
1c92bcc to
7ec7d83
Compare
nickvergessen
changed the title
nickvergessen
marked this pull request as ready for review
May 11, 2026 22:06
Signed-off-by: Joas Schilling <coding@schilljs.com>
This is kind of required as the frontpage which writes the session is the HTML request which can not send the header Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
feat/noid/allow-email-guests-without-public-link
branch
from
May 12, 2026 11:45
3a84564 to
fef4406
Compare
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
feat/noid/allow-email-guests-without-public-link
branch
from
May 12, 2026 11:52
fef4406 to
68a1df5
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
3 tasks
Contributor
This line in your PR now evaluates to spreed/src/composables/useGetMessages.ts Line 82 in e12e79d Before for public conversations it was |
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
deleted the
feat/noid/allow-email-guests-without-public-link
branch
May 13, 2026 13:28
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required