[stable33] test: migrate from Cypress to playwright - #64437
Merged
Merged
Conversation
backportbot
Bot
added
3. to review
susnux
force-pushed
the
backport/60194/stable33
branch
from
September 16, 2026 19:03
1ff79fe to
ae980eb
Compare
susnux
changed the title
Backport of all changes from `master` to migrate from Cypress to Playwright. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
The specs encode the frontend behaviour of the branch they were written for. Adapt the branch-sensitive ones and drop those covering features that only exist from Nextcloud 34 on: - the waffle app launcher and the configurable app store tile do not exist here, so `core/header-app-menu` and `core/admin-settings-appstore-link` are removed and `NavigationHeaderPage` models the inline app menu - the app store is part of the settings app, so `AppstorePage` uses its markup, routes and `/settings/apps/*` endpoints - accounts are edited inline in the user row instead of in an edit dialog - the account management sidebar has no combined account and group search, so `users-search` is removed - the settings navigation is server rendered and omits both captions for accounts without administration sections Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
The recommended apps view reads the app list from `settings/apps/list` and enables every selected app in a single `settings/apps/enable` request, then redirects to the default page. Stub those routes and assert the redirect instead of an inline per-app result. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
It is a new file, so it must not inherit the ownCloud copyright and the dual license of the other tsconfig files. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
A row that re-renders while its details are still loading drops back to read-only, so a single click on the toggle is not enough. Seen with an account whose manager was seeded before the page was opened. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…eration SHARE permission Link and email shares get the SHARE permission added by the server whenever `shareapi_allow_federation_on_public_shares` is enabled, which is the default. Comparing their raw permissions against the bundles therefore classified every public share as "Custom permissions" instead of the bundle it was created with. Match against the bundles through a helper that ignores that permission for public shares, while keeping the `exclude_reshare_from_edit` aware comparison for internal shares. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> (cherry picked from commit 8cfc129)
The title naming the storage, "{name} (unavailable)", arrived with the
accessible row name rework in 34. Backporting it would add a new
translatable string to a stable branch, so assert what is rendered here.
Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
backport/60194/stable33
branch
from
September 16, 2026 19:09
ae980eb to
9f2c285
Compare
susnux
marked this pull request as ready for review
September 16, 2026 19:10
susnux
requested review from
Altahrim,
come-nc,
icewind1991,
kristian-zendato and
sorbaugh
and removed request for
a team
September 16, 2026 19:10
susnux
approved these changes
Sep 16, 2026
artonge
approved these changes
Sep 16, 2026
AndyScherzinger
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #60194
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.