fix(ci): run performance tests against fetched PR changes - #63963
Open
joshtrichards wants to merge 1 commit into
Open
fix(ci): run performance tests against fetched PR changes#63963joshtrichards wants to merge 1 commit into
joshtrichards wants to merge 1 commit into
Conversation
Fix the performance-testing workflow so its after-measurements run against the actual fetched PR changes. Further harden the workflow by avoiding direct interpolation of PR-controlled values. Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
Altahrim,
CarlSchwan,
leftybournes and
sorbaugh
September 2, 2026 15:46
Member
Author
|
/backport to stable35 |
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
joshtrichards
added
2. developing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #Summary
Fix the performance-testing workflow so after measurements run against the actual fetched PR changes.
The workflow now:
FETCH_HEAD.The interpolation changes provide additional defense-in-depth when handling pull request-controlled values and allow us to remove a no-longer-needed
zizmor: ignore[...].TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)