fix(settings): show group display names in the 2FA group picker - #63867
Draft
NikolausDemmel wants to merge 1 commit into
Draft
fix(settings): show group display names in the 2FA group picker#63867NikolausDemmel wants to merge 1 commit into
NikolausDemmel wants to merge 1 commit into
Conversation
AdminTwoFactor.vue's "Enforced groups"/"Excluded groups" pickers fetched cloud/groups, which only returns a group's raw ID - so a group with a friendly display name but an opaque ID (e.g. one created by an app via IGroupManager::createGroup()) rendered as that opaque ID, with no way to visually confirm it's the right group. Switch to cloud/groups/details (id + displayname, already used elsewhere for the same purpose, e.g. RequestUserGroup.vue) and render via NcSelect's label prop. Also fetch by ID for any already-enforced/ excluded group missing from the initial page, so a previously configured group whose ID doesn't sort into the first page still resolves to a real display name - and remains selectable at all in the "excluded" input, since NcSelect can only show options present in :options. The initial page's ORDER BY gid ASC + fixed limit=20 (so an unfiltered load can still omit some groups entirely) is unchanged - that's shared with every other group picker using this pattern and out of scope here; search by display name already works today regardless. Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Nikolaus Demmel <nikolaus@nikolaus-demmel.de>
NikolausDemmel
force-pushed
the
fix-2fa-group-picker-63760
branch
from
August 31, 2026 23:26
2763746 to
dbf2923
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AdminTwoFactor.vue's "Enforced groups"/"Excluded groups" pickers fetched cloud/groups, which only returns a group's raw ID - so a group with a friendly display name but an opaque ID (e.g. one created by an app via IGroupManager::createGroup()) rendered as that opaque ID, with no way to visually confirm it's the right group.
Switch to cloud/groups/details (id + displayname, already used elsewhere for the same purpose, e.g. RequestUserGroup.vue) and render via NcSelect's label prop. Also fetch by ID for any already-enforced/ excluded group missing from the initial page, so a previously configured group whose ID doesn't sort into the first page still resolves to a real display name - and remains selectable at all in the "excluded" input, since NcSelect can only show options present in :options.
The initial page's ORDER BY gid ASC + fixed limit=20 (so an unfiltered load can still omit some groups entirely) is unchanged - that's shared with every other group picker using this pattern and out of scope here; search by display name already works today regardless.
Assisted-by: ClaudeCode:claude-sonnet-5
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)