[stable35] fix(ftp): handle empty port parameter and ensure strictly numeric ports - #63815
Merged
Conversation
backportbot
Bot
requested review from
Altahrim,
joshtrichards,
provokateurin,
salmart-dev and
sorbaugh
and removed request for
a team and
joshtrichards
August 31, 2026 08:04
backportbot
Bot
added
bug
3. to review
provokateurin
approved these changes
Aug 31, 2026
The external storage settings submit an empty string when the Port field is left blank. `??` only substitutes null or missing values, so `""` was assigned to $port and passed on to FtpConnection::__construct(), whose $port parameter is typed int. PHP rejects a non-numeric string there, so adding an FTP storage without a port ended in a TypeError and an HTTP 500 - after the configuration had already been saved. Fall back to the default port of 21 unless the configured value is numeric, mirroring the guard added for SFTP in #58350. Casting without the check would not work, because (int)"" is 0 rather than 21. Co-authored-by: Carl Schwan <carl@carlschwan.eu> Signed-off-by: bahman026 <bahman026@gmail.com>
joshtrichards
force-pushed
the
backport/63161/stable35
branch
from
August 31, 2026 10:54
a1c6af2 to
ff62428
Compare
joshtrichards
approved these changes
Aug 31, 2026
joshtrichards
added
4. to release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #63161