fix(provisioning_api): cap group listings and throttle group creation - #63671
Closed
pringelmann wants to merge 1 commit into
Closed
fix(provisioning_api): cap group listings and throttle group creation#63671pringelmann wants to merge 1 commit into
pringelmann wants to merge 1 commit into
Conversation
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The two group listing endpoints,
/cloud/groupsand/cloud/groups/details, returned every group on the instance when nolimitwas given. The details one is the expensive one, since it counts members per group. Both now default to 500, and requests can page through the rest withoffset. Creating a group is rate limited to 50 per ten minutes, matching the other write endpoints here.Warning
Clients that relied on getting everything back now get the first 500, with nothing in the response to say it was cut off.
Checklist
3. to review, feature component)stable32)AI (if applicable)