Skip to content

fix(comments): recreate comment editor on Activity tab remount #63505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jospoortvliet wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(comments): recreate comment editor on Activity tab remount #63505

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
228786e
fix(comments): recreate Vue app when re-mounting Activity sidebar com…
jospoortvliet Aug 23, 2026
75631a6
Update apps/comments/src/comments-activity-tab.ts
jospoortvliet Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/comments/src/comments-activity-tab.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { getComments } from './services/GetComments.ts'
* Register the comments plugins for the Activity sidebar
*/
export function registerCommentsPlugins() {
let app: App
let app: App | undefined

window.OCA.Activity.registerSidebarAction({
mount: async (el: HTMLElement, { node, reload }: { node: INode, reload: () => void }) => {
Expand All @@ -38,6 +38,7 @@ export function registerCommentsPlugins() {
unmount: () => {
// destroy previous instance if available
app?.unmount()
app = undefined
},
})

Expand Down
Loading