Skip to content

Port oauth2 to new Entity system - #63288

Open
CarlSchwan wants to merge 5 commits into
masterfrom
carl/oauth2-entity
Open

Port oauth2 to new Entity system#63288
CarlSchwan wants to merge 5 commits into
masterfrom
carl/oauth2-entity

Conversation

@CarlSchwan

Copy link
Copy Markdown
Member

Summary

Best to review commit by commit

  • Port to oauth2 tables to new Entity system
  • Use psalm:strict on oauth2 app
  • Use rector:strict on oauth2 app

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
From a security point of view, this is more robust as this prevents
side-channel timming attack. This is not really the case here as we
already have brute force protection but this doesn't hurt.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan added this to the Nextcloud 35 milestone Aug 15, 2026
@CarlSchwan CarlSchwan self-assigned this Aug 15, 2026
@CarlSchwan
CarlSchwan requested a review from a team as a code owner August 15, 2026 08:21
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Aug 15, 2026
@CarlSchwan
CarlSchwan requested review from icewind1991 and removed request for a team August 15, 2026 08:21
@CarlSchwan CarlSchwan added the technical debt 🧱 🤔🚀 label Aug 15, 2026
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant