Skip to content

[stable34] fix: make unified filter chip accessible - #63224

Merged
susnux merged 2 commits into
stable34from
fix/unified-search-chip-accessibility
Aug 17, 2026
Merged

[stable34] fix: make unified filter chip accessible#63224
susnux merged 2 commits into
stable34from
fix/unified-search-chip-accessibility

Conversation

@kristian-zendato

Copy link
Copy Markdown
Contributor

Summary

The remove control on unified search filter chips was a plain <span> with a click handler: it was not keyboard-focusable and had no accessible name, so screen reader and keyboard users could not remove an active filter.
This changes the control to a real <button> and adds a translated aria-label ("Remove filter: {text}") so assistive technology announces which filter will be removed. Styles were adjusted so the button keeps the previous visual appearance

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@kristian-zendato
kristian-zendato requested a review from a team as a code owner August 13, 2026 13:51
@kristian-zendato
kristian-zendato requested review from skjnldsv, sorbaugh and susnux and removed request for a team August 13, 2026 13:51
@github-actions github-actions Bot changed the title fix: make unified filter chip accessible [stable34] fix: make unified filter chip accessible Aug 13, 2026
@susnux susnux added this to the Nextcloud 34.0.3 milestone Aug 13, 2026
@susnux

susnux commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

/compile rebase

kristian-zendato and others added 2 commits August 17, 2026 11:19
Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command
nextcloud-command force-pushed the fix/unified-search-chip-accessibility branch from 1ad3dc2 to ad91bf0 Compare August 17, 2026 11:21
@susnux
susnux merged commit 72eea97 into stable34 Aug 17, 2026
145 of 147 checks passed
@susnux
susnux deleted the fix/unified-search-chip-accessibility branch August 17, 2026 12:56
@susnux

susnux commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

/backport 472bb53 to stable33

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[core] unified search chips are not in tab sequence

5 participants