feat: show recent people on contact icon - #63147
Conversation
|
@SebastianKrupinski I created another branch for your comment. |
| private const PREVIEW_AVATARS_LIMIT = 3; | ||
| private const PREVIEW_AVATARS_CACHE_TTL = 300; |
There was a problem hiding this comment.
| private const PREVIEW_AVATARS_LIMIT = 3; | |
| private const PREVIEW_AVATARS_CACHE_TTL = 300; | |
| private const int PREVIEW_AVATARS_LIMIT = 3; | |
| private const int PREVIEW_AVATARS_CACHE_TTL = 300; |
Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
4e8c964 to
b626252
Compare
|
Also @kristian-zendato @susnux we could consider the Teams support for it a follow-up as well. Not a strict blocker |
jancborchardt
left a comment
There was a problem hiding this comment.
Blocking this for now after some concern shared by @schiessle and @karlitschek in the Files planning call about this looking too much like what collaborative editors like MS Office (and we) do.
As a result it might seem like other people are in your files, which is of course not the case and an impression we do not want to create under any circumstances.
Any alternative ideas regarding this? Otherwise it would be ok to skip or postpone this item.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |



Summary
Makes the People (contacts) header menu more inviting by showing a stack of up to 3 overlapping avatars of recent contacts on the menu trigger, instead of only the contacts icon.
GET /contactsmenu/preview-avatarswhich returns the first 3 entries from the same unfiltered contacts list as the menu (Manager::getEntrieswith an empty filter), with optional team filtering matching the existing index endpoint.NcAvatarstack when at least 2 are available; otherwise keeps the existing contacts icon.width: fit-content) so the stack does not overlap notifications/profile and remains fully clickable.Screenshot
🏚️ Before
🏡 After
Checklist
3. to review, feature component)stable32)AI (if applicable)