fix(dav): bulk upload part validation and path-based file reload - #62808
Draft
joshtrichards wants to merge 4 commits into
Draft
fix(dav): bulk upload part validation and path-based file reload#62808joshtrichards wants to merge 4 commits into
joshtrichards wants to merge 4 commits into
Conversation
Avoid a nullable/ambiguous node: In particular, `getFirstNodeById()` doesn't guarantee which node it'll return. Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden the DAV bulk-upload endpoint when processing multipart file parts.
X-File-Pathand non-negative numericContent-Lengthheaders.Why
getFirstNodeById()can returnnulland does not guarantee which accessible node is selected when a file is reachable through multiple mounts. Reloading by the uploaded path is deterministic and avoids dereferencing a nullable result.Malformed multipart headers were also able to reach later upload handling code instead of being rejected during parsing.
Testing
X-File-Pathand invalidContent-Lengthvalues.Content-Length: 0remains accepted.getFirstNodeById()is not used.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)