fix(Session): Don't updateLastLoginTimestamp when logging in via token - #62558
Closed
marcelklehr wants to merge 1 commit into
Closed
fix(Session): Don't updateLastLoginTimestamp when logging in via token#62558marcelklehr wants to merge 1 commit into
marcelklehr wants to merge 1 commit into
Conversation
Otherwise $firstTimeLogin is never true in the future Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
requested review from
come-nc,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
July 27, 2026 09:46
come-nc
requested changes
Aug 3, 2026
come-nc
left a comment
come-nc
left a comment
Contributor
There was a problem hiding this comment.
This is not valid, this should still count as a login.
What would be the issue with setting $firstTimeLogin accordingly in both cases? A first login with a token is still a first login, no?
Contributor
|
Also, how is the token created without first login in? That troubles me 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where for users logging in for the first time via a client that uses tokens, no
<user>/files/subdir is created.Note: I'm not sure if this is the best possible fix.
Checklist
3. to review, feature component)stable32)AI (if applicable)