refactor(l10n): move language tag logic to backend - #6039
Open
elzody wants to merge 1 commit into
Open
Conversation
Moving the Nextcloud language + locale to BCP 47 language tag logic to the backend makes sense because it exists in two places when it should really exist in one. This keeps it maintainable. The backend is the natural place because requests to Collabora happen there, and the logic can be injected into the frontend via initial state. Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As outlined in #6034, the Nextcloud language and locale settings to BCP 47 language tag conversion needs to be refactored so it's only located in one place; right now it's in two places, which is unmaintainable.
Moving this logic to the backend makes sense because it exists in two places when it should really exist in one. This keeps it maintainable. The backend is the natural place because requests to Collabora happen there, and the logic can be injected into the frontend via initial state.
Assisted-by: ClaudeCode:claude-sonnet-5
Checklist