Skip to content

Allow Collabora Online to fetch settings config from richdocuments - #4965

Merged
elzody merged 2 commits into
nextcloud:mainfrom
mohit-marathe:iframe-settings
Aug 29, 2025
Merged

elzody merged 2 commits into
nextcloud:mainfrom
mohit-marathe:iframe-settings

Conversation

@mohit-marathe

@mohit-marathe mohit-marathe commented Aug 27, 2025

Copy link
Copy Markdown
Contributor

This allows Collabora Online to have an in-app settings iframe dialog just like the one in Nextcloud Settings -> Office

  • Target version: main

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@codewithvk codewithvk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Need +1 from Nextclouders.

@elzody

elzody commented Aug 28, 2025

Copy link
Copy Markdown
Collaborator

Rebasing onto the latest main branch should resolve most of the failing integration and Cypress tests. I expect the failures to be unrelated, as we have an issue on main right now with some development dependencies causing the failures.

For some more context, these changes allow Collabora to fetch user settings from Richdocuments, or do I misunderstand?

It will be used to fetch settings from the in-app settings dialog.

Signed-off-by: Mohit Marathe <mohit.marathe@collabora.com>
using the accessToken created for loading office document.

Signed-off-by: Mohit Marathe <mohit.marathe@collabora.com>
@mohit-marathe

Copy link
Copy Markdown
Contributor Author

For some more context, these changes allow Collabora to fetch user settings from Richdocuments, or do I misunderstand?

That's right. Now that I read the PR title, it does sound misleading. I'll change the title.

@mohit-marathe mohit-marathe changed the title Allow to fetch settings config from Office Allow Collabora Online to fetch settings config from richdocuments Aug 29, 2025

@elzody elzody left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

@elzody

elzody commented Aug 29, 2025

Copy link
Copy Markdown
Collaborator

/backport to stable32

@elzody
elzody merged commit e6faf58 into nextcloud:main Aug 29, 2025
72 checks passed
@pedropintosilva

Copy link
Copy Markdown
Contributor

Should be backported to 31 please :)

@elzody

elzody commented Sep 1, 2025

Copy link
Copy Markdown
Collaborator

/backport to stable31

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants