enh: Require API-Key for webDAV API - #1393
Merged
Merged
Conversation
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the security of the webDAV API by requiring API key authentication for recognize-related endpoints. The implementation adds a new API key management system and enforces validation through the webDAV plugin system.
- Adds API key generation and validation functionality through a new ApiKeyManager class
- Implements API key authentication in the webDAV PropFindPlugin with timeout-based expiration
- Moves plugin registration from XML configuration to runtime registration for proper hook timing
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| psalm-baseline.xml | Updates static analysis baseline to handle new dependencies and class references |
| lib/Public/ApiKeyManager.php | New class for generating encrypted API keys with timestamp validation |
| lib/Dav/Faces/PropFindPlugin.php | Enhanced with API key validation logic and beforeMethod hook for authentication |
| lib/AppInfo/Application.php | Moves plugin registration to runtime event listener for proper initialization timing |
| appinfo/info.xml | Removes XML-based plugin registration in favor of runtime registration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
marcelklehr
commented
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.