Skip to content

fix(FaceDetectionWithTitle): Rename vector column to face_vector - #1367

Merged
marcelklehr merged 1 commit into
mainfrom
fix/face-detection-with-title-vector-col-rename
Sep 8, 2025
Merged

fix(FaceDetectionWithTitle): Rename vector column to face_vector#1367
marcelklehr merged 1 commit into
mainfrom
fix/face-detection-with-title-vector-col-rename

Conversation

@marcelklehr

Copy link
Copy Markdown
Member

fixes #1365

fixes #1365

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
marcelklehr requested a review from Copilot September 8, 2025 07:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a column naming inconsistency by renaming the vector column to face_vector in the FaceDetectionWithTitle class. This change aligns the column and field mappings to use a more descriptive name that better reflects the purpose of storing face detection vectors.

  • Updated database column mapping from 'vector' to 'face_vector'
  • Updated corresponding field mapping from 'vector' to 'faceVector' following camelCase convention

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@marcelklehr
marcelklehr merged commit 4ffe87c into main Sep 8, 2025
40 of 42 checks passed
@marcelklehr

Copy link
Copy Markdown
Member Author

/backport to stable10

@marcelklehr

Copy link
Copy Markdown
Member Author

/backport to stable9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Undefined property: OCA\Recognize\Db\FaceDetectionWithTitle::$vector

2 participants