Skip to content

fix: Reuse Viewer's slideshow feature - #3826

Merged
artonge merged 1 commit into
masterfrom
fix/photos-slideshow-videos
Sep 2, 2026
Merged

fix: Reuse Viewer's slideshow feature#3826
artonge merged 1 commit into
masterfrom
fix/photos-slideshow-videos

Conversation

@artonge

@artonge artonge commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Instead of reimplementing it. This fix displaying videos in slideshows.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@artonge
artonge requested a review from susnux September 2, 2026 15:11
@artonge artonge self-assigned this Sep 2, 2026
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews javascript Javascript related ticket labels Sep 2, 2026
@artonge
artonge force-pushed the fix/photos-slideshow-videos branch 2 times, most recently from e3e4153 to 0de2488 Compare September 2, 2026 15:12
@artonge

artonge commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable35

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Sep 2, 2026
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Instead of reimplementing it. This fix displaying videos in slideshows.

Signed-off-by: Louis Chmn <louis@chmn.me>
@artonge
artonge force-pushed the fix/photos-slideshow-videos branch from 0de2488 to 3fc145b Compare September 2, 2026 16:15
@artonge

artonge commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

CI fialure unrelated

@artonge
artonge merged commit c58aa8d into master Sep 2, 2026
60 of 92 checks passed
@backportbot

backportbot Bot commented Sep 2, 2026

Copy link
Copy Markdown

The backport to stable35 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable35
git pull origin stable35

# Create the new backport branch
git checkout -b backport/3826/stable35

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3fc145b0

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3826/stable35

Error: Failed to clone repository: Failed to create working tree: error: RPC failed; HTTP 401 curl 22 The requested URL returned error: 401
fatal: expected flush after ref listing


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@artonge
artonge deleted the fix/photos-slideshow-videos branch September 2, 2026 19:22
@susnux

susnux commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

/backport to stable35

@backportbot

backportbot Bot commented Sep 2, 2026

Copy link
Copy Markdown

The backport to stable35 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable35
git pull origin stable35

# Create the new backport branch
git checkout -b backport/3826/stable35

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3fc145b0

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3826/stable35

Error: Failed to clone repository: Failed to create working tree: error: RPC failed; HTTP 401 curl 22 The requested URL returned error: 401
fatal: expected flush after ref listing


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working javascript Javascript related ticket

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants