chore: Enable rector - #1018
Open
CarlSchwan wants to merge 6 commits into
Open
Conversation
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
carl/rector
branch
from
August 24, 2026 17:01
f782404 to
02f0c1c
Compare
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
carl/rector
branch
from
August 24, 2026 17:26
02f0c1c to
f44e4f9
Compare
come-nc
reviewed
Aug 25, 2026
come-nc
reviewed
Aug 25, 2026
come-nc
reviewed
Aug 25, 2026
| typeDeclarations: true, | ||
| typeDeclarationDocblocks: true, | ||
| privatization: true, | ||
| instanceOf: true, |
Contributor
There was a problem hiding this comment.
Is it the one replacing !== null checks with instanceof? What is the incentive?
Member
Author
There was a problem hiding this comment.
Yeah, it's this rule. I just copied the rules from server
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Enabled now that they are final Signed-off-by: Carl Schwan <carl@carlschwan.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI (if applicable)