feat: add favorites management to the notes list#190
Draft
juliusknorr wants to merge 2 commits into
Draft
Conversation
juliusknorr
force-pushed
the
feature/swiftui-notes-list
branch
from
14d1da5 to
ced7cf6
Compare
juliusknorr
force-pushed
the
favorites
branch
3 times, most recently
from
7b7130e to
3456b77
Compare
juliusknorr
force-pushed
the
feature/swiftui-notes-list
branch
from
798bfbe to
b1dfbb8
Compare
juliusknorr
force-pushed
the
favorites
branch
2 times, most recently
from
28e1bc7 to
581a11c
Compare
juliusknorr
force-pushed
the
feature/swiftui-notes-list
branch
from
a4c63e4 to
b1dfbb8
Compare
Add a favorite toggle via leading swipe action and context menu, and sort favorites to the top within the current sort mode. Closes #52 Signed-off-by: Julius Knorr <jus@bitgrid.net> Assisted-by: ClaudeCode:claude-opus-4-8
Toggling favorite went through the generic update path, which stamped the note with the current time. In a date-sorted list that made the row jump and re-render a second time after the sync round-trip. Pass updateModified: false so a favorite toggle preserves the existing modification date. Signed-off-by: Julius Knorr <jus@bitgrid.net> Assisted-by: ClaudeCode:claude-opus-4-8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements favorites management in the SwiftUI notes list (#52):
The data model, persistence and network payloads already carried
favorite, so this is UI-only.Stacked on #189 (SwiftUI notes list redesign); please merge that first. Base this PR against
feature/swiftui-notes-list.Closes #52