fix: adopt UIScene lifecycle for iOS 26 launch#188
Open
juliusknorr wants to merge 1 commit into
Open
Conversation
The app created its window in the app delegate via UIMainStoryboardFile and never adopted the scene lifecycle, so iOS 26 terminated it on launch with NoSceneLifecycleAdoption. Add a scene manifest, move window creation, lifecycle and URL handling into SceneDelegate, and add SceneDelegate.swift to the app target sources (it was never compiled). Signed-off-by: Julius Knorr <jus@bitgrid.net> Assisted-by: ClaudeCode:claude-opus-4-8
juliusknorr
requested review from
i2h3 and
mpivchev
and removed request for
mpivchev
There was a problem hiding this comment.
Pull request overview
Updates the app’s launch and lifecycle wiring to properly adopt the UIScene-based lifecycle required on iOS 26, moving window creation and URL handling to SceneDelegate and aligning project/Info.plist configuration accordingly.
Changes:
- Add/enable
SceneDelegateto create theUIWindow, host the SwiftUI root view, and forward lifecycle + URL events. - Refactor
AppDelegateto remove window ownership and expose scene-forwarded lifecycle/URL handler methods. - Update Info.plist and Xcode project to use
UIApplicationSceneManifestand compileSceneDelegate.swift.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Source/SceneDelegate.swift | Creates the app window for the scene, hosts ContentView, forwards lifecycle + incoming URL handling. |
| Source/AppDelegate.swift | Removes window setup and consolidates lifecycle/URL behavior into explicit handlers called by SceneDelegate. |
| iOCNotes.xcodeproj/project.pbxproj | Adds SceneDelegate.swift to the app target’s compile sources. |
| Brand/iOCNotes.plist | Replaces main storyboard keys with UIApplicationSceneManifest referencing SceneDelegate. |
Comment on lines
+50
to
54
| func scene(_ scene: UIScene, openURLContexts URLContexts: Set<UIOpenURLContext>) { | ||
| for context in URLContexts { | ||
| _ = AppDelegate.shared.handleOpen(url: context.url) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On iOS 26 the app terminated on launch with
NoSceneLifecycleAdoption. It created itsUIWindowin the app delegate viaUIMainStoryboardFileand never adopted the scene lifecycle, which iOS 26 no longer allows.Changes
UIApplicationSceneManifestand dropUIMainStoryboardFile.SceneDelegate.SceneDelegate.swiftto the app target's compile sources; it was referenced but never compiled.Testing