fix(settings): Load guest details by user id instead of email - #1670
Merged
Conversation
CarlSchwan
approved these changes
Aug 21, 2026
The guest list passed the email address to GuestDetails, which requests
/apps/guests/api/v1/users/{userId}. That endpoint resolves shares by
user id, and hashing the email into the user id is the default, so
expanding a row showed an empty share list even though the "Received
shares" column of the very same row reported shares.
Verified against a guest with one incoming share: getGuestInfo() returns
one share for the user id and none for the email address.
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
CarlSchwan
force-pushed
the
fix/guest-details-panel-uid
branch
from
August 21, 2026 08:25
cd33460 to
fd4e123
Compare
CarlSchwan
enabled auto-merge
August 21, 2026 08:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guest list passed the email address to GuestDetails, which requests /apps/guests/api/v1/users/{userId}. That endpoint resolves shares by user id, and hashing the email into the user id is the default, so expanding a row showed an empty share list even though the "Received shares" column of the very same row reported shares.