fix(backend): Keep the display name ordering when searching guests - #1668
Merged
Merged
Conversation
CarlSchwan
approved these changes
Aug 21, 2026
CarlSchwan
enabled auto-merge
August 21, 2026 08:23
solracsf
disabled auto-merge
August 21, 2026 08:52
orderBy() replaces the order-by clause instead of appending to it, so the second call dropped the display name ordering and left the results sorted by user id only. With hashed user ids that ordering is effectively random, and it also decides which guests a limited search returns. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
solracsf
force-pushed
the
fix/display-name-sort-search
branch
from
August 21, 2026 08:55
7cfe3e4 to
da5c7c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
orderBy() replaces the order-by clause instead of appending to it, so the second call dropped the display name ordering and left the results sorted by user id only. With hashed user ids that ordering is effectively random, and it also decides which guests a limited search returns.