fix(backend): Upgrade outdated password hashes on email logins - #1667
Merged
CarlSchwan merged 1 commit intoAug 21, 2026
Merged
Conversation
CarlSchwan
approved these changes
Aug 21, 2026
checkPassword() accepts the user id or the email address, but handed the login name straight to setPassword(), which matches on uid_lower. When a guest with a hashed user id logged in with their email address the update therefore matched no row and the outdated hash stayed in place, so it was re-computed and dropped on every single login. Use the user id that the lookup already returned. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
CarlSchwan
force-pushed
the
fix/password-hash-upgrade-email-login
branch
from
August 21, 2026 08:26
62f1329 to
7d26801
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkPassword() accepts the user id or the email address, but handed the login name straight to setPassword(), which matches on uid_lower. When a guest with a hashed user id logged in with their email address the update therefore matched no row and the outdated hash stayed in place, so it was re-computed and dropped on every single login.
Use the user id that the lookup already returned.