fix(restrictions): Apply the app config overwrite to the typed getters - #1664
Merged
CarlSchwan merged 2 commits intoAug 21, 2026
Merged
Conversation
AppConfigOverwrite only overrode the deprecated getValue(). Server code has since moved to the typed getters, so the overwrite that lateSetupRestrictions() installs to force `shareapi_only_share_with_group_members` when "Hide other accounts from guests" is enabled was silently ignored by them. Most notably OC\Collaboration\Collaborators\UserPlugin reads the option with getValueString(), so the share recipient autocompletion offered guests every account of the instance instead of only the members of their own groups. OCA\Guests\Config::isSharingRestrictedToGroup() reads it with getValueBool() and was equally unaffected by the overwrite. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
fix/appconfig-overwrite-typed-getters
branch
from
August 21, 2026 08:43
e1cb047 to
4d53f9d
Compare
CarlSchwan
approved these changes
Aug 21, 2026
CarlSchwan
enabled auto-merge
August 21, 2026 08:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppConfigOverwrite only overrode the deprecated getValue(). Server code has since moved to the typed getters, so the overwrite that lateSetupRestrictions() installs to force shareapi_only_share_with_group_members when "Hide other accounts from guests" is enabled was silently ignored by them.
Most notably OC\Collaboration\Collaborators\UserPlugin reads the option with getValueString(), so the share recipient autocompletion offered guests every account of the instance instead of only the members of their own groups. OCA\Guests\Config::isSharingRestrictedToGroup() reads it with getValueBool() and was equally unaffected by the overwrite.