fix(tests): scope admin settings heading locator to the guests section - #1645
Conversation
Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>
|
The test (Playwright) job is green again ✅ Scoping the assertion to the app's own #guest-settings container makes it resolve to exactly one heading (our section Ready for review. 👀 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
The
test(Playwright) job has been red onmainand on every PR since around 2026-06-11. It is not caused by any guests change: between the last green run (2026-06-09) and the first red one (2026-06-11) the only commits were a Transifex l10n update and an AUTHORS entry, andadmin-settings.spec.tsitself is unchanged since it was added.The assertion trips Playwright strict mode:
The settings framework renders a visually-hidden page heading
<h1>carrying the active section name ("Guests"), which collides with our own section<h2>. That<h1>is server-side and predates this app; nothing in this repo changed. Thetestjob boots thecontinuous-integration-shallow-serverimage, a shallow clone ofnextcloud/servermaster taken at image build time innextcloud/docker-ci; it was last rebuilt on 2026-06-10 (build) and the first guests run afterwards is the first red one: green 2026-06-09 → red 2026-06-11, red on every run since.This scopes the locator to the app's
#guest-settingscontainer, which is exactly what Playwright's own error output suggests, so it matches only our section heading. No change to app behaviour.🤖 AI (if applicable)
Assisted-by: ClaudeCode:claude-opus-4-8