fix(settings): save the guest allowlist again - #1616
Conversation
|
Thank you for splitting this out :) I found one UI regression that is easy to fix, but otherwise looks good! |
- the allowlist NcSelect used @input, which @nextcloud/vue 9 no longer emits, so editing the allowed apps was never saved - rework the allowlist into a read-only chip list with an edit (pencil) button and a confirm (check) button that applies and saves; editing uses a draft, so closing the dropdown no longer saves Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>
2725401 to
457cfda
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
The Guests admin settings page no longer persisted changes to the app allowlist.
Cause
The allowlist
NcSelectstill used@input="saveConfig", which @nextcloud/vue 9 no longer emits (the same Vue 3 migration regression as #1323, and the allowlist-selector remainder of #995 that #1598 did not cover, since #1598 only fixed the on/off switches). Editing the list of allowed apps therefore sent noPUT /apps/guests/configand was lost on reload.Change
The selector is reworked to the inline-edit pattern used in Accounts management:
NcSelect; edits go to a draft. A confirm (check) button applies the draft and saves. Closing the dropdown no longer saves on its own, and the save no longer relies on the dead@inputevent.Split out of #1602 so it can be backported on its own. The default-quota feature from that PR follows as a separate PR once this one lands.
Fixes #1591
Testing
馃 AI (if applicable)
Assisted-by: ClaudeCode:claude-opus-4-8
Screenshots: