Skip to content

fix(settings): save the guest allowlist again - #1616

Merged
ernolf merged 1 commit into
mainfrom
ernolf/fix/persist-guest-allowlist
Jul 3, 2026
Merged

fix(settings): save the guest allowlist again#1616
ernolf merged 1 commit into
mainfrom
ernolf/fix/persist-guest-allowlist

Conversation

@ernolf

@ernolf ernolf commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

The Guests admin settings page no longer persisted changes to the app allowlist.

Cause

The allowlist NcSelect still used @input="saveConfig", which @nextcloud/vue 9 no longer emits (the same Vue 3 migration regression as #1323, and the allowlist-selector remainder of #995 that #1598 did not cover, since #1598 only fixed the on/off switches). Editing the list of allowed apps therefore sent no PUT /apps/guests/config and was lost on reload.

Change

The selector is reworked to the inline-edit pattern used in Accounts management:

  • The current allowlist is shown read-only as wrapping chips (the full list stays visible, no truncation) with an edit (pencil) button, indented under the "Limit guest access to an app's allowlist" switch it belongs to.
  • Clicking the pencil opens the NcSelect; edits go to a draft. A confirm (check) button applies the draft and saves. Closing the dropdown no longer saves on its own, and the save no longer relies on the dead @input event.
  • The reset button keeps working and now also refreshes the draft while editing.

Split out of #1602 so it can be backported on its own. The default-quota feature from that PR follows as a separate PR once this one lands.

Fixes #1591

Testing

  • Add and remove apps, confirm with the check button, reload: the selection persists.
  • Toggling the switch and the reset button still work.

馃 AI (if applicable)

  • The content of this PR was partly generated using AI
    Assisted-by: ClaudeCode:claude-opus-4-8

Screenshots:

image
image

Comment thread src/views/GuestSettings.vue
@pringelmann

Copy link
Copy Markdown
Contributor

Thank you for splitting this out :) I found one UI regression that is easy to fix, but otherwise looks good!

- the allowlist NcSelect used @input, which @nextcloud/vue 9 no longer emits, so editing the allowed apps was never saved
- rework the allowlist into a read-only chip list with an edit (pencil) button and a confirm (check) button that applies and saves; editing uses a draft, so closing the dropdown no longer saves

Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>
@ernolf
ernolf force-pushed the ernolf/fix/persist-guest-allowlist branch from 2725401 to 457cfda Compare July 3, 2026 10:54
@ernolf
ernolf merged commit d4eae42 into main Jul 3, 2026
44 of 45 checks passed
@ernolf
ernolf deleted the ernolf/fix/persist-guest-allowlist branch July 3, 2026 11:30
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't modify guests app's allowlist

2 participants