Skip to content

fix: Add missing index on email the guest_users table - #1600

Merged
icewind1991 merged 1 commit into
mainfrom
carl/add-missing-index
Jun 9, 2026
Merged

fix: Add missing index on email the guest_users table#1600
icewind1991 merged 1 commit into
mainfrom
carl/add-missing-index

Conversation

@CarlSchwan

Copy link
Copy Markdown
Member

The column was added on May 1 2025 with the Version4002 migration, later in 2026 the index was added to the existing migration, so there was some releases in the middle with users potentially missing the index.

Add a new migration which explicitely add the index if missing.

See #1542

馃 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

The column was added on May 1 2025 with the Version4002 migration, later
in 2026 the index was added to the existing migration, so there was some
releases in the middle with users potentially missing the index.

Add a new migration which explicitely add the index if missing.

Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan
CarlSchwan requested a review from nickvergessen June 9, 2026 08:23
@CarlSchwan CarlSchwan self-assigned this Jun 9, 2026
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Jun 9, 2026
@icewind1991
icewind1991 merged commit 9315c89 into main Jun 9, 2026
55 checks passed
@icewind1991
icewind1991 deleted the carl/add-missing-index branch June 9, 2026 08:54
@nickvergessen

Copy link
Copy Markdown
Member

The column was added on May 1 2025 with the Version4002 migration, later in 2026 the index was added to the existing migration, so there was some releases in the middle with users potentially missing the index.

I'm not really sure. My PR was open for a very long time and the migration was only merged in March this year.

@CarlSchwan

Copy link
Copy Markdown
Member Author

The column was added on May 1 2025 with the Version4002 migration, later in 2026 the index was added to the existing migration, so there was some releases in the middle with users potentially missing the index.

I'm not really sure. My PR was open for a very long time and the migration was only merged in March this year.

Ah! still doesn't hurt. I was investigating as it seems for some users the initial migration was not run #1564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants